Skip to content

Fix Flaky Test#7147

Closed
KobeNorris wants to merge 2 commits intoapache:masterfrom
KobeNorris:fix-flaky
Closed

Fix Flaky Test#7147
KobeNorris wants to merge 2 commits intoapache:masterfrom
KobeNorris:fix-flaky

Conversation

@KobeNorris
Copy link
Copy Markdown

@KobeNorris KobeNorris commented Aug 27, 2022

Fixed Flaky Test

Details

  • In this PR, the flaky test in org.apache.iotdb.cluster.query.ClusterPlanExecutorTest#testGetAllStorageGroupNodes has been verified then fixed.

  • Used Collections to sort allStorageGroupNodes and exceptedStorageGroupNodes (which is generated from IoTDB.metaManager.getAllStorageGroupNodes();).

  • Applied MNodeComparator implements Comparator<IStorageGroupMNode> to pass Spotless plugin.


This PR has:

  • been self-reviewed.
    • concurrent read
    • concurrent write
    • concurrent read and write
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods.
  • added or updated version, license, or notice information
  • added comments explaining the "why" and the intent of the code wherever would not be obvious
    for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold
    for code coverage.
  • added integration tests.
  • been tested in a test IoTDB cluster.

Key changed/added classes (or packages if there are too many classes) in this PR

Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, this is your first pull request in IoTDB project. Thanks for your contribution! IoTDB will be better because of you.

@KobeNorris KobeNorris closed this Aug 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant